Subject:	[xfbb] Pactor scan bug (FBB7.04j) ?
From:	Øyvind Hanssen
Date:	04 December 2003 13:58:20

20.6.2009 G4APL also applied this to(FBB7.04s4) Start Line 1157


Look at the following from drv_hst.c (starting at line 1157). Any '!' at the start
of commands to the PTCII are changed to '#' before they are sent to the PTC. 
But not for the TRX SCAN command. The result is that scanning does not work. 

The problem is that the change is done on a copy not the original text. Later in the
program, the change is done on the buffer such that other commands than the
TRX SCAN work correctly. I added an extra line to fix this, but it may be better to 
change it in once and for all in the buffer?? 

Am I right that this is a bug? 

73 de LA7ECA, Øyvind

-----

	nb = sscanf (buffer, "%s %s %s", cmde, scan, val); 

	if (cmde[0] == '!')
		cmde[0] = '#';

	if ((nb == 3) && (strcmpi (cmde, "#TRX") == 0) && (strncmpi (scan, "SCAN", strlen (scan)) == 0))
	{
		if (isdigit (*val)) 
		{
			 if (atoi (val) > 0)
			 {
				cmd = (PortData *) m_alloue (sizeof (PortData));
				cmd->next = NULL;
				cmd->canal = canal;
				cmd->cmd = COMMAND;
				cmd->len = strlen (buffer);
				strcpy (cmd->buf, buffer);
				cmd->buf[0] = '#';                  /* LA7ECA Hack */
				hst_startscan (port, cmd);
				return 1;
			}
			pactor_scan[port] = 0;
		}
	}